Transliteration error

[preetcharan]

On the transliteration for 'pair' letter ShabadOS is producing the @ sign.

See image below:

Letter should be ignored in the transliteration

Mac OS Mojave iMac Shabad OS App Version 2.9.0, Database Version 4.7.0

[bhajneet]

@Harjot1Singh adding this works:

What's currently in place doesn't work idk why:

[Harjot1Singh]

Could you check if passing any other character in the supressions list causes it to be displayed? Perhaps we should write a test case for this.

[bhajneet]

Yeah I was just investigating that. None of the suppressions were actually being suppressed. I added two test cases, will sort it out.

[bhajneet]

Very confused

Transliteration map seems correct per first parameter of console log. Transliteration doesn't suppress per second and third parameters of console log. Transliteration works if adding line 195.

Going to unassign myself

[Harjot1Singh]

I see! It's because of the passthrough: transliterationMap[ '@' ] === '' == false, therefore the || letter kicks in. Did you push the test cases up anywhere?

[bhajneet]

I didn't push, but I just added the OP word and khanda symbol as two tests

On Wed, Dec 30, 2020, 12:32 Harjot Singh notifications@github.com wrote:

I see! It's because of the passthrough: transliterationMap[ '@' ] === '' == false, therefore the || letter kicks in. Did you push the test cases up anywhere?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/shabados/gurmukhi-utils/issues/185#issuecomment-752699922, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLZ3B4RL6S4T7SNEQAXNNLSXNP4TANCNFSM4VODE7WA .