search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

Add right click functionality #154

Open bhajneet opened 5 years ago

bhajneet commented 5 years ago

You should be able to right click a navigator line and "copy, get info, share"

Selecting "copy" can bring up a menu that shows all relevant lines for that id ({ascii, unicode} gurmukhi, english/spanish translation, transliteration, etc.).

As a gui option each line could have three dots to the right side of it that can be clicked for the same menu.

bhajneet commented 4 years ago

Right click should also work for search results to allow copy, more info (ID, source, author, etc.), and in the future perhaps "save to bookmarks"

bhajneet commented 4 years ago

Right click menu should also be activateable by hotkey. So if a user is highlighting a search result and hits ctrl+c, g to copy the gurbani, the ctrl+c should show the copy menu with options for gurbani, english translation, etc that shows the hotkey for it's activation (in this case g is for gurbani, the g could be underlined, not sure if this works for all of them).

Harjot1Singh commented 4 years ago

@bhajneet any mockups, or just standard right-click menu for now?

bhajneet commented 4 years ago

Standard works for now. I'm curious how VS Code handles this across windows / macOS?

This is how it looks on Windows:

image

Vs the default on Windows:

image

Harjot1Singh commented 4 years ago

@visionthroughdesign don't worry about implementing the functionality to actually copy, we can the functionality implemented in https://github.com/ShabadOS/desktop/pull/400 to just do that, as long as we have the GUI working

Harjot1Singh commented 4 years ago

One more note, i came across this: https://material-ui.com/components/menus/, there's a context menu there, can use it perhaps