Closed Harjot1Singh closed 4 years ago
Could you explain this a little more? As I understand you are asking for the ability to start the program in full screen with no navigator/controller being shown. If you're on windows and are automating the task you can use AutoHotKey to Ctrl+F and Ctrl+H after the window opens. It is not ideal, but perhaps we can look into improving this via native / gui options in the future.
^^ as you've said. AHK is what I had planned to use, but it's obviously not ideal for Gurdwaras or non-technical users. I don't mind chucking in a PR if this project is still in active development.
It should not be too hard to add two options in settings:
Would very much appreciate any PRs, already saw your dockerise request which I will look into later as I'm on vacation currently. Yes, this project is "active" and we are often thinking about improvements/overarching directions.
Awesome. Is there anywhere that we can discuss general direction etc? Would love to suggest a few things, and give my feedback from a technical and user experience perspective.
Hi, your website gave a "mail server down" error. Please send an email to the team with contact info.
Ooo, thanks for letting me know about that! Sent an email to your team.
Dev branch: Do we need to add gui options for "open in fullscreen" and "hide controller on start"?
If so, both options should be set to "true" by default
Should the controller be hidden by default on start?
Yes, but not minimized
Same with titlebars or any other UI elements
Only thing that should be seen is a bg (by theme) and the title "Shabad OS" animation in the middle
Can rename "Hide controller on start" to "Hide UI on start"
@bhajneet would this just be for the main window?
That would be a good start. Ultimately, it should apply to any "presenter" window that is opened on startup. Not sure what the spec is for #456. I would imagine that the "main window" is the full screen controller (which is different from this issue), and that the other displays would all be presenters, which if this issue's feature is toggled on would start up in full screen windows.
Goal is for a gurdwara to be able to start their "server/PC" without having to actually configure anything. They can then use their mobile devices / alternate PCs to control the projectors.
@bhajneet im testing this right now and if i set the fullscreen option to true, everything pops in fullscreen ( the app, settings, etc). Is this what we want?
We only want the initial windows that are loaded onServerReady to be fullscreened
Im not sure why other windows are also being full screened (settings etc) even mainWindow is only one
You might be setting a global value. Make sure you instead iterate over getDisplayWindows
export from windows.js
and call fullscreen
for each of those.
it still doesnt exclude the settings for some reason...
playing around with a workaround for mac rn
There should be a way of setting the display window to fullscreen by default, hiding the menu. This is useful in the situation that core/desktop is installed on a laptop, and you just want to control it from a phone or laptop straight away.