shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

Implement better bookmarks #20

Closed Harjot1Singh closed 4 years ago

Harjot1Singh commented 6 years ago

How would one use this for an Akhand Paath? Couldn't seem to find anything relating to this, nor figure out what the Akhand Paath View does.

bhajneet commented 6 years ago

Akhand Paath View is supposed to make it so that when you are at the end of a shabad and press the down key or are at the beginning of a shabad and press the up key it should go to the next or previous shabad, respectively. It is set as an option so some people aren't caught by surprise when the shabad is changed so easily. (Otherwise you would use the ctrl+{Up,Down} to change the shabad.) Basically, it is to make it so you can keep pressing down over and over again to go through every single shabad. This will be helpful in the future when we incorporate using a powerpoint/keynote clicker to change lines as well.

Perhaps we can change the name to "Akhand Path Mode" instead of "View" to reduce confusion.

Harjot1Singh commented 6 years ago

I see. If I was to use this for an Akhand Paath, what would be the procedure? Could we add some documentation? I really like this project, and would love to see this in Gurdwaras more!

bhajneet commented 6 years ago

Well if you were using this for an Akhand Paath, it would only be to ease usage since you only have to hit the down key over and over (and over and over) again. If Akhand Paath mode was disabled, you would have to use the ctrl+down arrow shortcut. So you could do an Akhand Path either way, one would just be easier since you don't have to watch out for last lines or anything.

Once we play around with presentation clickers, we will hotkey it's up and down buttons to what is currently our up and down arrow keys on the keyboard. This will let you use a clicker to navigate an entire Akhand Paath once the current line is found.

Documentation would be great. Using Shabad OS in more gurdwaras would be even greater!

Harjot1Singh commented 6 years ago

Makes sense. The only confusion for me was that I couldn't figure out how to get this to work with an Akhand Paath/how to start it alongside an Akhand Paath, since it doesn't work when you reach the end of Japji Sahib, and you have to search for the beginning of SGGS to start it from there.

I suspect it would help Gurdwara uptake if these sorts of things were documented, would be happy to contribute to this as well, I suspect in the website repo?

bhajneet commented 6 years ago

I can understand your confusion, esp if you went in from the bookmarks section. We had not thought of that scenario.

If we removed the option in Settings and made it a bookmark it would mean we need a different way to find the current line / page if starting at any other point other than the beginning of an Akhand Paath.

Another idea is instead to leave the option as is, but re-name to something that means you can go to next and previous shabads using just the up and down key in addition to the ctrl shortcut and add a bookmark as "Akhand Paath" which is actually just the first shabad (mool mantar only in the database I believe).

Or perhaps to re-think how we are setting up all our banis and allow people to "leave" japji sahib at the last line. Whether that should take them to the rehraas as in akhand paath or to the next bani in nitnem, idk how to reconcile.

Have to think through this a little more.

Documentation is a great idea, please do not contribute in the website repo just yet. Adding our documentation to the website is a good idea too, but perhaps there is another option of just using our github documentation pages as these repo's have a wiki as well. Any thoughts on which you prefer and why?

Harjot1Singh commented 6 years ago

Agreed, I think this should be opened up further and mapped out properly.

GH pages for documentation; it's pretty, and you have the option of generating documentation from comments if so desired in the future.

Harjot1Singh commented 6 years ago

Thinking about this again, should this mode not be the default behaviour? Are there any major downsides of having this by default, and not presenting the option, avoiding clutter?

bhajneet commented 6 years ago

We don't want people to accidentally change the shabad and then be confused about how to get back. One idea of ours was to not allow change on down-arrow-held unless there was a separate down-arrow press on the last line specifically. But even that caused some confusion.

An option I can think of is to append a faux-line to each shabad that says "Go to next shabad". This line could be activated for GUI heavy users (And also creates an option for mouse-only users, since there is currently no way for them to do this).

On avoiding clutter, we should have different menus in the settings page, it can't just be one long page anymore. One other idea is to change the menu icon to not load a new page, but to pop-up a system menu which is simply a bunch of toggles. This is a benefit in the scenario that someone wants to change settings while inside a shabad. Instead of having to juggle navigation arrows and worrying about not activating the line-being-sung it is much easier to keep them both available at the same time.

Harjot1Singh commented 6 years ago

I agree. Change the menu icon to a settings icon, and then pop out is the way forward. Able to create an issue?

Harjot1Singh commented 6 years ago

We can think about the points regarding the next shabad in more detail once we've completed Q1?

bhajneet commented 6 years ago

If we change the menu icon to a settings icon, what will happen to things like "Live Captions Tool" and "Connect to..." menus? Could move them to a different icon, but I prefer to keep the controller clean (It already looks cluttered to some new users).

We can talk about "next shabad" after Q1

Harjot1Singh commented 6 years ago

Oh, I forgot how the current menu looks - it already has settings. I agree.

bhajneet commented 5 years ago

Based on the discussion above and over the year, it seems that there should be a way to do a couple things:

bhajneet commented 5 years ago

Asa Di Vaar and other larger banis should also be split up into a folder

bhajneet commented 4 years ago

To be broken up into separate issues

bhajneet commented 4 years ago

Duplicate of #483