Open bhajneet opened 4 years ago
These need animations/way for the user to understand what holding the hotkey does before it activates
In the example of holding the key down
, right
, l
, or left-click
on the last line of a shabad should start to fill up some progress bar of sorts saying "next shabad" or such which when filled activates the long-press hotkey. In the UI with an unhidden controller it could be a new "line" after the last one which slides up and says "Next shabad" and fills up for whatever amount of time we set for long-press hotkeys (I'm going to suggest half a second for now, but definitely something over 300ms)
I'd also like to see "holding" of down, right, or l
in an open controller for navigator scroll down the list of lines without actually activating any of them. The viewport would be scrolling, and whatever line is closest to the middle would be highlighting/activating at the end.
When we have #237 we can make it so long pressing the scrolling of the viewport will switch to a pseudo-selector / non-activated one which requires enter to actually display.
Long press would also close #177
I think #177 is still useful for mobile environments, no?
True, and and probably the same use case for GUI only users/mouse only users.
Perhaps we can have the next shabad always visible but also activatable by long press on the line before it.
Another general question/thought I have: long-press hotkeys, or most hotkeys for that matter should be accessible through the GUI, given that they're meant to be shortcuts. So it's worth thinking about how we can replicate these behaviours. Perhaps holding down the history icon is what holding ctrl-y maps to
Yeah that's a good point re: GUI
I've updated the original table
I also think there should be some way to "see" the hold happening. So some progress bar, or circle circumference that fills up clockwise, etc.
Depends on #394 and #462 / #154 for further evaluation
"Long" as over 300ms (proposal to test).
More ideas, for discussion: