Harjot1Singh
commented
4 years ago -
Enter a shabad for first time -> add main line
-
Exit shabad -> add line to history
-
Grouped like m mockup, current line header at top (with jump to navigator or some text) as grouped entry
-
History header with grouped entries (depends on #235)
The history timeline is not properly showing lines as expected.
If a user searches a line that line should be set to main and inserted into history. Any line activated after this should go into history next. Such that someone searches a shabad (it is entered into history correctly), and then the last line they activate in this shabad should go into history as well. Then if they go to a different shabad / bookmark and check history they can see the main line as well as the last line they activated. This is less jarring and offers better feedback choices for the user.
This does not need to be done for bookmarks which can keep only "one" position. regardless of which one you choose in the history timeline activity.
Currently I noticed if I search a shabad (line 4) it is entered into history as line 4. Then if I leave on line 6 and search a different shabad, the different shabad shows up as entry 1 and the first shabad line 4 shows up as entry 2 (it should be line 6 as entry 2 and line 4 as entry 3, there is no entry 3). Then when going to entry 2 in today's system (which shows line 4 in history), it will take me to line 6 (already confusing) and this line 6 is entered into the history timeline, but this line does not update in history based on what is activated in shabad.