search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

Implement non-deletable hotkeys and addable hotkeys for certain hotkey functions #426

Closed bhajneet closed 3 years ago

bhajneet commented 4 years ago

These two hotkeys should never be removable, but there could be extra hotkeys added for it.

Originally posted by @bhajneet in https://github.com/ShabadOS/desktop/issues/425#issuecomment-589661538

Harjot1Singh commented 4 years ago

any others?

bhajneet commented 4 years ago

Probably arrow keys (though j and l can be removed I suppose)

I would think anything that is super core to the concept of using shabad os should not be configurable. Arrows, enter, hide controller, full screen. Maybe activities as well? /, y, b, g. I would think it odd if someone changed the esc key for clearing as well. These should remain "core" hotkeys that anyone who needs to use shabad os elsewhere can use.

What do you think?

Harjot1Singh commented 4 years ago

I actually think that all hotkeys should be all be reassignable. You may wish to change the activate line hotkey to ., and I see nothing wrong with that.

The only ones that I think should be fixed are arrow up and down + enter in the controller, and that’s it, because they’re not really hotkeys

bhajneet commented 4 years ago

I just don't want to go to a different gurdwara and not be able to use basic hotkeys. So whatever you want to define as basic hotkeys needed for the most basic functioning of shabad os with the controller hidden on a single-presentation display will work for me. I think those are ctrl+h, arrows, enter, esc, spacebar, and number 1 key/home key.

bhajneet commented 4 years ago

This doesn't mean they can't add a hotkey "." to activate the line. It's not being used for any of the basic hotkeys so you can add that on to the enter hotkey.