more info in search results

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams

https://shabados.com

MIT License

19 stars 15 forks source link

more info in search results #510

Closed saihaj closed 4 years ago

saihaj commented 4 years ago

[X] Data from backend
[X] Render meta data and translit/ translation in search results
[X] Style the results similar to mobile mockup
[x] Setting to choose different translation (dropdown)
[x] Setting to choose different translits (dropdown)
[x] Add option to hide meta data ~~Tutorial button~~

Let me know if we should allow user to choose metadata and rearrange it to their liking (part of this PR or a new feat)?

Closes #225

saihaj commented 4 years ago

[x] @Harjot1Singh need to fix server settings. Not working because of f0e060a.
[x] I need to integrate the settings with the menu options once I figure out how translation will work because of different sources we have.
[X] Also waiting on how to display source names View in Slack

@bhajneet take a look at icons and let me know if we need to change them.

saihaj commented 4 years ago

https://github.com/ShabadOS/database/issues/1767 will take care of short source names. But will depend on release. So for time being need to make a function that will take care of that. Will need to update in future once latest version of DB is released.

saihaj commented 4 years ago

[x] Need to fix full-word search d2739016a1ab989f4ea048c0b61cb5c1af0fb6d2
[x] Translations don't show up after reloading the application.Values exist in local storage but something up with the values being passed down to the component. (Research) Update: So what I found for above is that something is wrong with getTranslation() need to investigate further. https://github.com/ShabadOS/desktop/blob/a41144d955a5008edc6beeec4b5d3c87ef0a6871/app/frontend/src/Controller/Search.js#L177-L183
[x] @Harjot1Singh fix performance issue check Slack conversation for details.

bhajneet commented 4 years ago

Off in dropdown should be "None". Though I still prefer radio buttons for user customizability in case they want to see english and punjabi translation at the same time for instance.

The other option is to add "checkmarks" to dropdown so you select multiple options in each dropdown. This would cut down on space used but still allow the same functionalilty. I don't necessarily think we have the hours to spend on such implementations, so highly recommend the simple radio buttons if possible.

bhajneet commented 4 years ago

Font weights:

Punjabi too heavy
Translit not making matching heavier than non-matching as gurmukhi does

Line heights:

Urdu not tall enough

bhajneet commented 4 years ago

Fix short titles to use two words for Bhai Nand Laal compositions as per source:

saihaj commented 4 years ago

My only concern is that it will be messy. Purpose of this is to help Search in some way. If we add an option to choose multiple then we are basically making a Presenter window (that is too long to scroll down). If they want to read them they are only click away from that anyway. #419 will also help because we will add all those features into it.

english and punjabi translation at the same time for instance

Update: Read this on Slack

Harjot1Singh commented 4 years ago

The search component needs some serious refactoring lol

saihaj commented 4 years ago

Probably make search results as a component in future if we do something with #521

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 4691a996ca4cf8a9ef8777326d039ed625172546 into 1a7e357728d39130335d656b0d67711de4a9a544 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class