Closed saihaj closed 4 years ago
@bhajneet take a look at icons and let me know if we need to change them.
https://github.com/ShabadOS/database/issues/1767 will take care of short source names. But will depend on release. So for time being need to make a function that will take care of that. Will need to update in future once latest version of DB is released.
getTranslation()
need to investigate further. https://github.com/ShabadOS/desktop/blob/a41144d955a5008edc6beeec4b5d3c87ef0a6871/app/frontend/src/Controller/Search.js#L177-L183Off in dropdown should be "None". Though I still prefer radio buttons for user customizability in case they want to see english and punjabi translation at the same time for instance.
The other option is to add "checkmarks" to dropdown so you select multiple options in each dropdown. This would cut down on space used but still allow the same functionalilty. I don't necessarily think we have the hours to spend on such implementations, so highly recommend the simple radio buttons if possible.
Font weights:
Line heights:
Fix short titles to use two words for Bhai Nand Laal compositions as per source:
My only concern is that it will be messy. Purpose of this is to help Search in some way. If we add an option to choose multiple then we are basically making a Presenter window (that is too long to scroll down). If they want to read them they are only click away from that anyway. #419 will also help because we will add all those features into it.
english and punjabi translation at the same time for instance
Update: Read this on Slack
The search component needs some serious refactoring lol
Probably make search results as a component in future if we do something with #521
This pull request introduces 1 alert when merging 4691a996ca4cf8a9ef8777326d039ed625172546 into 1a7e357728d39130335d656b0d67711de4a9a544 - view on LGTM.com
new alerts:
Tutorial buttonLet me know if we should allow user to choose metadata and rearrange it to their liking (part of this PR or a new feat)?
Closes #225