search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

Some lines should still be truncated after 3+ lines worth #523

Closed bhajneet closed 4 years ago

bhajneet commented 4 years ago

image

While I'm happy to show as much information as possible, this is actually breaking the built-in/popped-in controller. You can't even see the gurbani when using up/down arrows.

Is there a way to truncate after n chars? Maybe 300 characters to test

@sarabveer I'm also wondering if these translations are aligned incorrectly? Perhaps that could resolve this issue too

saihaj commented 4 years ago

My suggestion is one line and truncate because most of the search result will be consistent and if the user wants to read they can open the full shabad. Purpose is to help search in someway not to cause any confusions

bhajneet commented 4 years ago

There's very few over 2 lines, if you can truncate after 2 lines that's best

bhajneet commented 4 years ago

This should not affect gurbani or pronunciation/translits at all

bhajneet commented 4 years ago

Nor citation lol

Only translations should be truncated I think since we don't know how long some of them are

saihaj commented 4 years ago

Agreed

saihaj commented 4 years ago

Resolution took 15 mins.