Closes https://github.com/ShabadOS/desktop/issues/170. Does not change the functionality of the firstLetter search highlighting, but modifies the fullWord highlighting to include all words.
Before
After
First letter search still works
How was this tested?
I tried the following test cases:
The word is at the beginning of the line.
The word comes after a special character.
Trailing space after the word.
Ensured the first letter search still worked.
Happy to write unit tests once those exist (if they exist).
Other odds and ends
I didn't have permission to push to ShabadOS/desktop, and the instructions said to fork so that's what I did - not as well versed with the workflow so let me know if I need to change things.
I was surprised at some of the eslint rules, especially the extraneous semicolon being enforced.
Summary
Closes https://github.com/ShabadOS/desktop/issues/170. Does not change the functionality of the
firstLetter
search highlighting, but modifies thefullWord
highlighting to include all words.Before
After
First letter search still works
How was this tested?
I tried the following test cases:
Other odds and ends
I didn't have permission to push to ShabadOS/desktop, and the instructions said to fork so that's what I did - not as well versed with the workflow so let me know if I need to change things.
I was surprised at some of the eslint rules, especially the extraneous semicolon being enforced.
Reviewers
@saihaj @Harjot1Singh