search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
18 stars 15 forks source link

Consolidate styling #546

Open Harjot1Singh opened 4 years ago

Harjot1Singh commented 4 years ago

Is your feature request related to a problem? Please describe. Common Material UI components are being styled at the local component level. This means that for every dialog we make, we have to restyle it with the same properties. It also means that we make more mistakes when it comes to regression and ensuring our theme has full coverage in our app.

Describe the solution you'd like Global application of Material UI styles, using the themes.

Describe alternatives you've considered

Additional context We have a lot of these component styles defined in SettingsComponent.css.

saihaj commented 4 years ago

Please also see https://cssinjs.org/?v=v10.1.1, which i've used succesfully in other projects btw, this is lit. Think it's the way forward, but not a priority rn. It'd help us from having to style each thing individually View in Slack

saihaj commented 4 years ago

I think in the future, we should start thinking about bundling up our own component library/UI presets etc. https://github.com/ShabadOS/theme-tool/pull/47#pullrequestreview-438785398

We can get rid of MaterialUI all together and just use CSS-in-JS with ShabadOS-styles lib since it will be helpful for website redesign and other projects (DB viewer, theme tool, connect and future projects)