feat(frontend/settings): add os.release to about page and sentry logger

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams

https://shabados.com

MIT License

19 stars 15 forks source link

feat(frontend/settings): add os.release to about page and sentry logger #560

Closed bhajneet closed 4 years ago

bhajneet commented 4 years ago

Summary of PR

Add release info to about page, this info can also be used in loggers so logs will reflect which os is running more effectively

Tests for unexpected behavior

since adding a feature, I don't think there could be anything broken by something as simple as this

Time spent on PR

13 mins of reading docs, 1 minute of coding, 1 minute of PR = 15 mins

Linked issues

Fix #365

Reviewers

@Harjot1Singh

Harjot1Singh commented 4 years ago

@bhajneet I'll leave it up to you if you'd like to do this now, but it might be worth sending this information to sentry too - see https://github.com/ShabadOS/desktop/blob/dev/app/lib/analytics.js

bhajneet commented 4 years ago

That's a good idea, I'll convert this to a draft for now