the custom hotkeys for first / last in navigator were lower priority than the default navigation hotkeys used in other activities
Also updated the settings page:
Tests for unexpected behavior
used different shabads as tests
confirmed not breaking banis
tried in other activities for whatever reason
Time spent on PR
About 3 hours. Spent about 30 minutes figuring out where the issue was coming from. Then another 2 hours trying to fix it. Then spent 5 minutes on copying the solution being used in search.js to navigator.js Remaining time was spent on thinking through hotkey names/descriptions for settings.
Summary of PR
the custom hotkeys for first / last in navigator were lower priority than the default navigation hotkeys used in other activities
Also updated the settings page:
Tests for unexpected behavior
Time spent on PR
About 3 hours. Spent about 30 minutes figuring out where the issue was coming from. Then another 2 hours trying to fix it. Then spent 5 minutes on copying the solution being used in
search.jstonavigator.jsRemaining time was spent on thinking through hotkey names/descriptions for settings.Linked issues
Fix #504
Reviewers
@Harjot1Singh