search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

feat(frontend/presenter): only advance on click if focused #577

Closed Harjot1Singh closed 4 years ago

Harjot1Singh commented 4 years ago

Summary of PR

Only advances the presenter slide if the window is focused. Uses an approach of taking a mouse click as a focus event on anything that is not Mac, and the focus event on Mac.

See #388 for more description and considered solutions.

Tests for unexpected behavior

Time spent on PR

Linked issues

Closes #388

Reviewers

@bhajneet

bhajneet commented 4 years ago

Can you test this on an iPad/mobile device of sorts? Single tap should advance a line

On Wed, Jun 3, 2020, 08:06 Harjot Singh notifications@github.com wrote:

@Harjot1Singh https://github.com/Harjot1Singh requested your review on:

577 https://github.com/ShabadOS/desktop/pull/577

feat(frontend/presenter): only advance on click if focused.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ShabadOS/desktop/pull/577#event-3401835957, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLZ3BZVW2NEK3BUWTUZV6DRUY4DNANCNFSM4NRTJJDQ .

Harjot1Singh commented 4 years ago

Can you test this on an iPad/mobile device of sorts? Single tap should advance a line … On Wed, Jun 3, 2020, 08:06 Harjot Singh @.***> wrote: @Harjot1Singh [@Harjot1Singh](https://github.com/Harjot1Singh) requested your review on: #577 <#577> feat(frontend/presenter): only advance on click if focused. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#577 (comment)>, or unsubscribe <github.com/notifications/unsubscribe-auth/ADLZ3BZVW2NEK3BUWTUZV6DRUY4DNANCNFSM4NRTJJDQ> .

It does