Closed Harjot1Singh closed 4 years ago
Updates to gurmukhi-utils@3.1.0. This allows for removing some existing code and refactoring to use more of gurmukhi-utils.
gurmukhi-utils@3.1.0
gurmukhi-utils
Inserting and deleting accents are resolved, as the input is no longer converted to ascii (but let me know if this behaviour is incorrect).
Also does not incorrectly highlight full word matches with any trailing spaces.
Finally, first-letter searching with accented characters like Z will correctly return results.
Z
1.5hrs
Fixes #166 Fixes #344 Fixes #540
@bhajneet
Summary of PR
Updates to
gurmukhi-utils@3.1.0
. This allows for removing some existing code and refactoring to use more ofgurmukhi-utils
.Inserting and deleting accents are resolved, as the input is no longer converted to ascii (but let me know if this behaviour is incorrect).
Also does not incorrectly highlight full word matches with any trailing spaces.
Finally, first-letter searching with accented characters like
Z
will correctly return results.Before
After
Tests for unexpected behavior
Time spent on PR
1.5hrs
Linked issues
Fixes #166 Fixes #344 Fixes #540
Reviewers
@bhajneet