shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

feat: unify accent insertion and match accented first letter input #579

Closed Harjot1Singh closed 4 years ago

Harjot1Singh commented 4 years ago

Summary of PR

Updates to gurmukhi-utils@3.1.0. This allows for removing some existing code and refactoring to use more of gurmukhi-utils.

Inserting and deleting accents are resolved, as the input is no longer converted to ascii (but let me know if this behaviour is incorrect).

Also does not incorrectly highlight full word matches with any trailing spaces.

Finally, first-letter searching with accented characters like Z will correctly return results.

Before

image

image

After

image

image

Tests for unexpected behavior

Time spent on PR

1.5hrs

Linked issues

Fixes #166 Fixes #344 Fixes #540

Reviewers

@bhajneet