search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

ci: github workflow #582

Closed saihaj closed 3 years ago

saihaj commented 4 years ago

Summary of PR

image

Time spent on PR

2 hours

Reviewers

@Harjot1Singh

saihaj commented 4 years ago

Can't really remove CCI, since we need it for releases. I don't know how to deal with signing and publishing?

saihaj commented 4 years ago

@Harjot1Singh we have 2 options to choose from when creating and publishing release using gihtub actions:

  1. We create a release using actions/create-release@v1 and generate changelog (You can see example of this here -> https://github.com/saihaj/ShabadOSdesktop/runs/973714966). Then we have another workflow in which we create binaries for OS and then using this bruceadams/get-release@v1.2.0 we get the draft release we created and upload assets to it and finally update the release to mark it published using something like johnwbyrd/update-release@v1.0.0

  2. Other option is that will allows us to keep one file. We extend on what I have right now for CI once the binaries are built we upload them to GitHub actions artifacts section(similar to CCI job) using actions/upload-artifact@v2 and then have a new job that will depend on build step (once all the binaries have been built and uploaded to gh-actions artifacts section) we create a release using actions/create-release@v1, retrieve built binaries using actions/download-artifact@v2 and upload them to our release using actions/upload-release-asset@v1

bhajneet commented 3 years ago

Please rename the title of the PR to match our commit guidelines

I think in this case the type would be "build" instead of "ci"

saihaj commented 3 years ago

I am just removing cci config and adding GH workflows and according to the guideline

ci: Changes to our CI configuration files and scripts (e.g. with scopes: Circle, BrowserStack, SauceLabs)

If I make it "build" that wouldn't make sense

build: Changes to our build system or external dependencies (e.g. with scopes: gulp, broccoli, npm)

bhajneet commented 3 years ago

That is my bad, I honestly didn't know we had a "ci" type -- My apologies!

Harjot1Singh commented 3 years ago

@saihaj what's the difference to what comes out, between the two?

bhajneet commented 3 years ago

@saihaj are you planning on working on this? if not, close the PR. If it's something you want to work on but can't because you're waiting on something else change the status from Hold to "Blocked" so it's in the correct PM column.

saihaj commented 3 years ago

Now we have the actions repo we will most likely use those. I guess it is easier to just make a new one