feat(frontend/settings): theme tool

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams

https://shabados.com

MIT License

19 stars 15 forks source link

feat(frontend/settings): theme tool #583

Closed saihaj closed 4 years ago

saihaj commented 4 years ago

Summary of PR

Adds a button in overlay settings to link to theme tool and also changes the description.

Before

After

Time spent on PR

30 minutes

Linked issues

Fix #506

Reviewers

@Harjot1Singh

bhajneet commented 4 years ago

There is a very clear 2-column pattern of key & values. To have two buttons designed like this is confusing to the pattern. Please use one button per row/line.

bhajneet commented 4 years ago

Additionally, the theme tool could just be in the Learn More button, no? Keep it simple and use the existing paradigms in place for advanced learning/usage.

saihaj commented 4 years ago

Should we revert this back and make the change?

Harjot1Singh commented 4 years ago

I’d suggest PR’ing the change (since dev isn’t a release, reverting doesn’t serve a point if we’re going to recommit).

The Learn More button provides a lot of information that a user may not ever know about, and that the theme tool has no link to. So, it would make sense to still keep both buttons.