Closed saihaj closed 3 years ago
This should not have been opened for review with such a noticeable style issue.
Possibly related to https://github.com/ShabadOS/desktop/issues/519
@Harjot1Singh should I address #519 in new PR or do it here? @bhajneet is the button layout change acceptable though?
It might actually make more sense to do #519 first if it won’t take too long, and merge it in
@bhajneet MaterialUI Grid and Button have some sort of padding is causing the green lines as shown in your screenshot.
Can you add a css rule for sibling of button to remove it's top padding?
Removing top padding doesn't help. I also tried margin but that didn't work.
That yellow region is the one that needs to be removed somehow.
Yeah, so that would be top margin then. Rule would be similar to
.MuiButtonbase-root + .MuiButtonbase-root {
margin-top: 0;
}
What is happening with this PR @saihaj?
I think me and @bhajneet were trying to do something and that didn’t work. Can you please run it locally and see. I think this is what the issue is https://github.com/ShabadOS/presenter/pull/586#issuecomment-653923315
Too stale
Summary of PR
Changes position of overlay button in settings
Before
After
Time spent on PR
2 mins
Related
https://github.com/ShabadOS/desktop/pull/583#issuecomment-651404400
Reviewers
@bhajneet @Harjot1Singh