search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

fix(frontend/settings): change theme tool button position #586

Closed saihaj closed 3 years ago

saihaj commented 4 years ago

Summary of PR

Changes position of overlay button in settings

Before

image

After

image

Time spent on PR

2 mins

Related

https://github.com/ShabadOS/desktop/pull/583#issuecomment-651404400

Reviewers

@bhajneet @Harjot1Singh

bhajneet commented 4 years ago

This should not have been opened for review with such a noticeable style issue.

image

bhajneet commented 4 years ago

Possibly related to https://github.com/ShabadOS/desktop/issues/519

saihaj commented 4 years ago

@Harjot1Singh should I address #519 in new PR or do it here? @bhajneet is the button layout change acceptable though?

Harjot1Singh commented 4 years ago

It might actually make more sense to do #519 first if it won’t take too long, and merge it in

saihaj commented 4 years ago

@bhajneet MaterialUI Grid and Button have some sort of padding is causing the green lines as shown in your screenshot.

image
bhajneet commented 4 years ago

Can you add a css rule for sibling of button to remove it's top padding?

saihaj commented 4 years ago

Removing top padding doesn't help. I also tried margin but that didn't work.

image

That yellow region is the one that needs to be removed somehow.

image
bhajneet commented 4 years ago

Yeah, so that would be top margin then. Rule would be similar to 

.MuiButtonbase-root + .MuiButtonbase-root {
  margin-top: 0;
}
Harjot1Singh commented 3 years ago

What is happening with this PR @saihaj?

saihaj commented 3 years ago

I think me and @bhajneet were trying to do something and that didn’t work. Can you please run it locally and see. I think this is what the issue is https://github.com/ShabadOS/presenter/pull/586#issuecomment-653923315

bhajneet commented 3 years ago

Too stale