search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

Line numbers are showing up in copying of lines when line numbers are set to hidden #587

Closed bhajneet closed 4 years ago

bhajneet commented 4 years ago

Describe the bug Copying is showing line number when presenter/overlay/search is hiding the line number.

Expected behavior For copy to respect what is displayed on presenter/overlay/search

saihaj commented 4 years ago

Can be a good candidate for long press hotkeys #352

bhajneet commented 4 years ago

Don't need an alternate hotkey, but a fix to the current hotkey. If someone copies a line and there is no line ending shown, then there should be no line ending copied.

On Sun, Jul 5, 2020 at 8:23 PM ਸਹਜਪ੍ਰੀਤ ਸਿੰਘ notifications@github.com wrote:

Can be a good candidate for long press hotkeys #352 https://github.com/ShabadOS/desktop/issues/352

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ShabadOS/desktop/issues/587#issuecomment-653959625, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLZ3B2MEYJKBG5VZJC4XHLR2EKPLANCNFSM4ORDOM2Q .

saihaj commented 4 years ago

Fixing this based on value of presenter setting