search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
18 stars 15 forks source link

fix: vertical paddings of buttons in settings #588

Closed saihaj closed 3 years ago

saihaj commented 4 years ago

Summary of PR

Increases margin top and bottom

Tests for unexpected behavior

Before image

After image

Time spent on PR

5 mins

Linked issues

Fix #519

Reviewers

@bhajneet @Harjot1Singh

Harjot1Singh commented 4 years ago

@bhajneet does this look ok to you?

bhajneet commented 3 years ago

@saihaj can you please share an image of the first two buttons being used vertically with this vertical-padding-fix?

bhajneet commented 3 years ago

Also the two css selectors should be unified imo. There should not be the same setting applied to two css selector rules.

saihaj commented 3 years ago

@saihaj can you please share an image of the first two buttons being used vertically with this vertical-padding-fix?

586 will do that