search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
18 stars 15 forks source link

fix: correctly toggle in and out of fullscreen on hotkey in browsers #603

Closed Harjot1Singh closed 3 years ago

Harjot1Singh commented 3 years ago

Summary of PR

Previously only was toggling into fullscreen but not out in web browser environments. Does not check or exit on the same keypress (ctrl-f).

Tests for unexpected behavior

Time spent on PR

Linked issues

Fix #oopsie

Reviewers

@saihaj @bhajneet

bhajneet commented 3 years ago

Apparently have to downgrade babel-eslint

saihaj commented 3 years ago

I will work on that in a new PR with few more changes to deps