feat(frontend): add inline transliterations to source gurmukhi - Githubissues

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams

https://shabados.com

MIT License

19 stars 15 forks source link

feat(frontend): add inline transliterations to source gurmukhi #607

Closed bhajneet closed 3 years ago

bhajneet commented 3 years ago

This can be used in camps to help teach gurmukhi from it's english equivalent

note: it is no longer possible to justify gurmukhi/source line (center text and primary pause wrapping continue to work fine)

This also renders transliterations on the fly, and no longer fetches them from database. This should result in a performance enhancement for loading times.

Additionally, code refactoring occurred to make the line components more maintainable and logical.

Fixes #248

Summary of PR

Tests for unexpected behavior

various settings combos juggled around in browser

@Harjot1Singh tests:

Copy transliterations + translations hotkeys
Overlays with different content enabled
Presenter with different content enabled
Escaping in and out of content

Time spent on PR

5-6 hours
Harjot 3-4 hours

Linked issues

Fix #248

Reviewers

@Harjot1Singh

Comments

I can also add a "guide" option such as "Column Lines for Inline Transliterations", it would perhaps look something like this:

bhajneet commented 3 years ago

@sarabveer once this is merged and GU is released, I can add laghu/deeragh numberings to each word

Harjot1Singh commented 3 years ago

Justifying doesn't work in this mode only, correct? Looks cool! Will review properly soon.

bhajneet commented 3 years ago

I actually did not test justify source line without transliterations. I think I should be able to get that to work perhaps, by shuffling around CSS at worst.

Harjot1Singh commented 3 years ago

Unable to run this PR.

Attempted import error: 'faCompressAlt' is not exported from '@fortawesome/free-solid-svg-icons'.

Did you have #605 checked out before?

Harjot1Singh commented 3 years ago

Standard layout is broken

bhajneet commented 3 years ago

added another option, need to fix the css in some layouts, not sure how it broke -- will take a look on sunday

Harjot1Singh commented 3 years ago

Do we want column guides when there are no inline transliterations?

bhajneet commented 3 years ago

Yes, because we may use them for syllabic weight representation, dictionary results, one-to-one translations, etc besides just translit

They can also be used as an alternate to rang chhed / pad chhed for larrivaar assist (if CSS is done properly)

Harjot1Singh commented 3 years ago

@bhajneet please check this out and try to break it. There's relatively significant code restructuring and simplification on some parts, to do with trnaslations and transliterations.

Harjot1Singh commented 3 years ago

I'm unable to push because of this?

Harjot1Singh commented 3 years ago

Moved to #623