search

shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
18 stars 15 forks source link

build: do not start electron by default in development #611

Closed Harjot1Singh closed 3 years ago

Harjot1Singh commented 3 years ago

Summary of PR

Removes Electron from default start command. Got annoying have an electron shell spawn every time.

Time spent on PR

1 minute

Reviewers

@bhajneet @saihaj

Harjot1Singh commented 3 years ago

Start === dev, no?

On 26 Oct 2020, at 22:24, Saihajpreet Singh notifications@github.com wrote:

 @saihaj requested changes on this pull request.

I think then we should have a dev command that can run start electron

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

saihaj commented 3 years ago

yes but what I am suggesting is that we should have a script that can let someone start electron too if needed

Harjot1Singh commented 3 years ago

npm run start:electron, no?

bhajneet commented 3 years ago

yes but what I am suggesting is that we should have a script that can let someone start electron too if needed

The existing npm run start:electron should continue to work. So you could do npm start and then if you wanted to test electron, could run npm run start:electron in a new terminal

Correct me if I'm wrong @Harjot1Singh