shabados / presenter

Desktop app for presenting the Shabad OS Database on projectors, TVs, and live streams
https://shabados.com
MIT License
19 stars 15 forks source link

feat(frontend): add inline transliterations to presenter gurmukhi #623

Closed Harjot1Singh closed 3 years ago

Harjot1Singh commented 3 years ago

MOVED FROM #607

This can be used in camps to help teach gurmukhi from it's english equivalent

note: it is no longer possible to justify gurmukhi/source line (center text and primary pause wrapping continue to work fine)

This also renders transliterations on the fly, and no longer fetches them from database. This should result in a performance enhancement for loading times.

Additionally, code refactoring occurred to make the line components more maintainable and logical.

Fixes #248

Summary of PR

image

Tests for unexpected behavior

@Harjot1Singh tests:

Time spent on PR

Linked issues

Fix #248

Reviewers

@Harjot1Singh

Comments

I can also add a "guide" option such as "Column Lines for Inline Transliterations", it would perhaps look something like this:

image

bhajneet commented 3 years ago

Great work!

image

image