Spring cleaning - Githubissues

shabados / viewer

An online viewer of the Shabad OS Database

https://viewer.shabados.com

MIT License

6 stars 6 forks source link

Spring cleaning #380

Closed bhajneet closed 2 years ago

bhajneet commented 2 years ago

Summary

Did clean up of files / styles
Refactored screens to separate folder and created a helpers folder
Updated icons / pwa set up for current brand assets
Added prettier and vscode files similar to mobile repo
Installed JSS (css-in-js)
Added an about page and cleaned up home page

Test

ran npm run lint
ran npm run test

Duration

10+ hrs

First 3 hours: did some research into various css-in-js vs styled jsx
Last 7 hours: died trying to get babel-eslint to work for shared config, need to do major upgrade, @harjot1singh will handle switchover to Vite

lgtm-com[bot] commented 2 years ago

This pull request introduces 3 alerts and fixes 2 when merging 0cd098146870947a045a08fb15a3eec27a4d9a3d into b554b5b1b12b1348e21bf5c1aac6ea24a35eeb9a - view on LGTM.com

new alerts:

1 for Useless conditional
1 for Use of externally-controlled format string
1 for Missing rate limiting

fixed alerts:

1 for Useless conditional
1 for Missing rate limiting

lgtm-com[bot] commented 2 years ago

This pull request introduces 3 alerts and fixes 2 when merging 3c7079d8b19f232b94d1d64ab5898dc4616b633b into b554b5b1b12b1348e21bf5c1aac6ea24a35eeb9a - view on LGTM.com

new alerts:

1 for Useless conditional
1 for Use of externally-controlled format string
1 for Missing rate limiting

fixed alerts:

1 for Useless conditional
1 for Missing rate limiting

lgtm-com[bot] commented 2 years ago

This pull request introduces 3 alerts and fixes 2 when merging 64bc3bfc85163dea9b588cf61f0d778272e6a8a3 into b554b5b1b12b1348e21bf5c1aac6ea24a35eeb9a - view on LGTM.com

new alerts:

1 for Useless conditional
1 for Use of externally-controlled format string
1 for Missing rate limiting

fixed alerts:

1 for Useless conditional
1 for Missing rate limiting

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts and fixes 2 when merging 4c54e539beb470a2dfcf97db9ff0ecd492df886e into b554b5b1b12b1348e21bf5c1aac6ea24a35eeb9a - view on LGTM.com

new alerts:

1 for Use of externally-controlled format string
1 for Missing rate limiting

fixed alerts:

1 for Useless conditional
1 for Missing rate limiting