search

shabbychef / fromo

Fast Robust Moments in R with Rcpp
3 stars 1 forks source link

You probably have yourself a memory leak #33

Closed shabbychef closed 5 years ago

shabbychef commented 5 years ago

not a big one, but the assignment of a new Welford object looks suspicious. perhaps we should use tare and assign in?

shabbychef commented 5 years ago

I did indeed; valgrind is your friend, e.g.

R --vanilla -d 'valgrind' < runall.r  2>&1 | less

This was fixed by 94e8bb442 , specifically checking for ord > 1 in the Welford code.