Only require typing_extensions on Python 3.7 and older

shabbyrobe / grpc-stubs

gRPC typing stubs for Python

MIT License

35 stars 21 forks source link

Closed gitpushdashf closed 3 years ago

gitpushdashf commented 3 years ago

Corrects a typo in README.rst.

Newer mypy versions output double quotes instead of single quotes.

shabbyrobe commented 3 years ago

Thanks for the PR, this looks good.

Do you happen to know which mypy version introduced the change? We should probably set that ti be the minimum in the version constraint.

gitpushdashf commented 3 years ago

Thank you! I'm glad it looks good.

From what I can tell, it happened going from mypy 0.812 to 0.900. 0.902 is out right now.

Do you want me to update dev-requirements.txt accordingly?

shabbyrobe commented 3 years ago

Yes please. Maybe we could start with 0.902 and wind it back (or forward) if anybody has trouble?

gitpushdashf commented 3 years ago

Ok, that's done.

gitpushdashf commented 3 years ago

Thank you!