search

shabbyrobe / grpc-stubs

gRPC typing stubs for Python
MIT License
35 stars 21 forks source link

Fix request iterator type #24

Closed ilianovoselov-foodpairing closed 2 years ago

shabbyrobe commented 2 years ago

Thanks for the PR! Could you please share a short snippet demonstrating the issue this was causing you?

ilianovoselov-foodpairing commented 2 years ago

Hi, just our interceptor had Iterator type in overridden method signature. Looking back at it, I think I could make it work with iterable, but I found a place in the code which makes me think that the type should be actual iterator: https://github.com/grpc/grpc/blob/master/src/python/grpcio/grpc/_channel.py#L203