search

shabbyrobe / grpc-stubs

gRPC typing stubs for Python
MIT License
35 stars 21 forks source link

Typeshed #4

Open snallapa opened 4 years ago

snallapa commented 4 years ago

Hello 👋. I found this repo and this works really well with mypy. I was wondering if you had any plans of including this in typeshed so that it is automatically included in mypy. I am not sure the exact amount of work needed but it does not sound like a lot. If you do not have the time, I might be able to try to do it as well if you want! Thank you for making this either way!

shabbyrobe commented 4 years ago

Hi snallapa, thanks for your interest! I had originally thought I would try to submit back to typeshed, but IIRC I read somewhere that they weren't adding more third party stuff any more and that stub packages like this were the way forward. I can't remember where I read that though, and my memory may not serve me correctly as it was some time ago now.

I'd be happy to try to submit if there was a chance it would be accepted.

snallapa commented 4 years ago

I think they are taking PR for third party libraries now! I actually just added types for a library https://github.com/python/typeshed/pull/3845 and they are usually pretty quick to respond. Hopefully, I did not misread any of their information or misunderstand something but lmk if I did. It would be great to have this included in typeshed

shabbyrobe commented 4 years ago

That's good to know! One of my concerns is that there doesn't appear to be any testing of the stubs in typeshed. The typed-django folks reached out to me to suggest I use their mypy testing plugin and it worked really well, I intended to use it more and more as I add updates. I'm slightly worried moving this to typeshed would mean that I have to remove that testing, which would make updating the stubs riskier. What are your thoughts?

snallapa commented 4 years ago

That is not something I really considered! I think it might be worth adding an issue on typeshed and talking to them about it as they can probably add their thoughts or maybe already have a solution?

r-kells commented 3 years ago

Interested in being a part of this too. It looks like typeshed would expose these stubs to a lot more users!

jenstroeger commented 1 year ago

I think it’d be worthwhile moving this to Typeshed Stubs , unless Google is willing to integrate it into the official Python grpc packages.

shabbyrobe commented 1 year ago

I've reached out in the typeshed repo. Let's see if it's something they'd consider.

hauntsaninja commented 1 year ago

so that it is automatically included in mypy

Note that typeshed stubs for third party packages are not automatically included with mypy (at least, not in the last couple years). However, it is true that typeshed stubs are relatively more discoverable.

shabbyrobe commented 7 months ago

I've opened the PR: https://github.com/python/typeshed/pull/11204