shabiel / M-Web-Server

A YottaDB and Caché compatible HTTP server
Apache License 2.0
24 stars 19 forks source link

Escape Keys during JSON encoding #14

Closed ChristopherEdwards closed 5 years ago

ChristopherEdwards commented 5 years ago

Keys can contain data that should be escaped. Also add test containing data that should be escaped.

ChristopherEdwards commented 5 years ago

@shabiel I don't have a full test environment setup for the re-namespaced version of this, but everything should work. If a second verification could be done it would be appreciated.

shabiel commented 5 years ago

You broke a unit test:

LABELS - unusual labels. LABELS^%webjsonEncodeTest - unusual labels - <{"top":[{"10":"number 10",",":"comma",":":"colon","\":"backslash","a":"normal letter"}]}> vs <{"top":[{"10":"number 10",",":"comma",":":"colon","\":"backslash","a":"normal letter"}]}> - no failure message provided

Can you try again?

--Sam

On Thu, Jan 31, 2019 at 2:36 PM Christopher Edwards notifications@github.com wrote:

@shabiel I don't have a full test environment setup for the re-namespaced version of this, but everything should work. If a second verification could be done it would be appreciated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ChristopherEdwards commented 5 years ago

Of note that line isn't valid JSON according to JSON validator (or any of the tools i've used)

screen shot 2019-02-01 at 8 50 20 am
ChristopherEdwards commented 5 years ago

I'll update the validation line to have two "\" which should make the test pass