Closed ChristopherEdwards closed 5 years ago
@shabiel I don't have a full test environment setup for the re-namespaced version of this, but everything should work. If a second verification could be done it would be appreciated.
You broke a unit test:
LABELS - unusual labels. LABELS^%webjsonEncodeTest - unusual labels - <{"top":[{"10":"number 10",",":"comma",":":"colon","\":"backslash","a":"normal letter"}]}> vs <{"top":[{"10":"number 10",",":"comma",":":"colon","\":"backslash","a":"normal letter"}]}> - no failure message provided
Can you try again?
--Sam
On Thu, Jan 31, 2019 at 2:36 PM Christopher Edwards notifications@github.com wrote:
@shabiel I don't have a full test environment setup for the re-namespaced version of this, but everything should work. If a second verification could be done it would be appreciated.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Of note that line isn't valid JSON according to JSON validator (or any of the tools i've used)
I'll update the validation line to have two "\" which should make the test pass
Keys can contain data that should be escaped. Also add test containing data that should be escaped.