shabnamkousha / codepath

Todo List
0 stars 0 forks source link

[Android Bootcamp] Project 0: Todo - Ready for Review #1

Open shabnamkousha opened 8 years ago

shabnamkousha commented 8 years ago

@codepathreview and @codepath

Please review the project. Code is fully functional, meeting the requirements in the pre-work text. Please refer to README for more info and the walkthrough demo.

nesquena commented 8 years ago

Shabnam,

Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project-based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn the practical elements of Android development and best practices as quickly as possible. We also do a code review for each submitted project once the program begins.

The next step is to continue working on extensions to your todo app and to schedule a short 10 minute phone conversation with us. Navigate to today's date and onward from there and choose a 15-minute slot. Let us know if none of those times work.

With regards to extensions to implement, we are looking for developers with an interest in user experience and product development so be sure to focus on additional functional enhancements and/or improving the user interface of the app.

Once you select a slot, can you make sure to include best number to reach you at to the invite? Look forward to chatting soon!

shabnamkousha commented 8 years ago

I just integrated sqlite database into the app. Now the todo items are being persisted into SQLite instead of a text file. I tried to take the simplest approach to finish this task. Of course there is room for improvement. For example, using primary key, I can make item update process more efficient.

nesquena commented 8 years ago

Great, glad to see you added SQLite support now! We'd like to see you add a functional improvement to the app and/or improve the UI / UX and update the GIF. You can read details for other extension ideas in the prework snippet. Ping us once you've added and we'll take another look.

shabnamkousha commented 8 years ago

Thanks for the comment. I'm on it. Should be ready by tonight, midnight or so. Thanks!

shabnamkousha commented 8 years ago

I just uploaded the latest code and Walkthrough Gif file (included in README). I added more functionalities but didn't get time to make the app look very fancy; However, I added some icons and made some style changes to learn the concept. Thanks!

nesquena commented 8 years ago

Hi Shabnam,

Great to see you were able to augment your app with a number of extension tasks now. As mentioned earlier, the extension tasks available on each project are often the most valuable learnings since they dive deeper into common real-world Android use cases. After reviewing your project, I'd encourage you to take a look at this guide on code organization best practices to cleanup your source code.

We'll be in touch with you again soon via email. Let me know if you have any questions about the project or anything in the meantime.

shabnamkousha commented 8 years ago

Hi,

I pushed the cleaned up code to the repository. This weekend, I am going to redo parts of the code and add some stylings/features to the app. Thanks!