search

shacker / django-todo

A multi-user, multi-group todo/ticketing system for Django projects. Includes CSV import and integrated mail tracking.
http://django-todo.org
BSD 3-Clause "New" or "Revised" License
822 stars 285 forks source link

Connect users in tracked mail tasks #116

Closed fross123 closed 2 years ago

fross123 commented 3 years ago

I tweaked one of the logs for the tracker because it was failing a test. Hopefully it still logs what you need, I apologize if it doesn't.

Also, the feature discussed in #112. It works well in my pretty limited situation. I wound up adding a setting and only matching if settings.TODO_MATCH_USERS is true to make sure that current users would not be affected unnecessarily.

Thanks!

shacker commented 3 years ago

@fross123 - @multun Did a code review on this last April, and I was just wondering if you were going to be able to follow up on his comments?

shacker commented 3 years ago

No response from the OP. Does anyone want to see this PR continue? If so, speak up. Otherwise I'm going to close it without merging.

fross123 commented 3 years ago

@shacker Sorry for the delay, I kind of forgot about this. I wound up going back to work shortly after I made this PR...

If you want to close that's fine with me, otherwise I am happy to take a look again in a few days and make those changes.

shacker commented 3 years ago

@fross123 Definitely still interested in having the PR, if you feel like it's close and you're willing!

fross123 commented 3 years ago

Sorry about the delay in this folks. I've pushed some updates, let me know what you think. Wasn't too sure about the change requested to the setting, so I will update when we discuss that further.

Thanks!