search

shacker / django-todo

A multi-user, multi-group todo/ticketing system for Django projects. Includes CSV import and integrated mail tracking.
http://django-todo.org
BSD 3-Clause "New" or "Revised" License
819 stars 285 forks source link

Skip module check because it blocks automated installs #133

Closed wasare closed 2 years ago

wasare commented 2 years ago

My idea was import django before the check.py to skip the blocking error. Any feedback will be appreciated.

2022-01-26_18-31-django-todo

shacker commented 2 years ago

@wasare Under what circumstances are you seeing this problem?

wasare commented 2 years ago

The problem occurs in a CI workflow (with github actions). When run pip install -r requirements.txt django is installed along side with your package but the envoirnment does not loaded (or register) the package before install the all dependencies. I understand is a particular case, fixing it i could share the problem and help others.

shacker commented 2 years ago

OK that makes sense to me, and I can't see any downside. Thanks for the PR!