shad7 / seedbox

Seedbox Task Manager
http://shad7.github.io/seedbox
MIT License
10 stars 0 forks source link

[TASK] Simplified custom torrent parser #30

Closed shad7 closed 9 years ago

shad7 commented 9 years ago

The custom torrent parser that was in use had extra methods that were not needed and the code was more complex than necessary. Removed the extra methods and the inner class, and created simple Bdecode class that handles parsing a proper torrent file.

Added test cases to make sure custom parser is completely tested and follows the entire torrent spec.

Review on Reviewable

landscape-bot commented 9 years ago

Code Health Repository health decreased by 0.41% when pulling 4c438c5 on task/misc into f8d40d5 on develop.

landscape-bot commented 9 years ago

Code Health Repository health increased by 0.09% when pulling bd75adc on task/misc into f8d40d5 on develop.

shad7 commented 9 years ago

Review status: all files reviewed, all discussions resolved, some commit checks pending. Reviewed files:


Comments from the review on Reviewable.io