shadabahmed / logstasher

Awesome rails logs
MIT License
818 stars 136 forks source link

Memory leak with latest version of logstasher #109

Closed MarcGrimme closed 8 years ago

MarcGrimme commented 8 years ago

Hi folks, for me it looks like the current logstasher gem has a serious memory leak. How comes: This commit removes all previous custom_fields: LogStasher.custom_fields.clear. This happened even through a request which was the problem. So the commit above fixed this but now the custom_fields are never cleaned up. This means during lifetime of a process (unicorn, whatever) of your Rails app the memory consumption grows. To make it worse the custom_fields are added with the same fields over again which even increases memory pressure more. We've seen this in production now 3 times. It's fix time I guess. So this is the issue and hopefully the fix comes soon. Fix here #110

MarcGrimme commented 8 years ago

Fixed in #110