search

shadabahmed / logstasher

Awesome rails logs
MIT License
821 stars 136 forks source link

Allow event's fields renaming #124

Closed ayashjorden closed 7 years ago

ayashjorden commented 8 years ago

Added 'field_renaming' configuration option

We used this feature to let Elastic/FileBeat ship logs directly to ES instead to Logstash and the to ES.

Comments are welcome, Yarden

shadabahmed commented 8 years ago

Thanks for the PR @ayashjorden .. I can merge it today

shadabahmed commented 8 years ago

Can you look at the failing tests though ? @ayashjorden

ayashjorden commented 7 years ago

@shadabahmed, I'm getting the following bundle error:

Fetching gem metadata from https://rubygems.org/
Fetching version metadata from https://rubygems.org/
Fetching dependency metadata from https://rubygems.org/
Resolving dependencies.............................
Bundler could not find compatible versions for gem "activerecord":
  In Gemfile:
    logstasher was resolved to 1.0.1, which depends on
      activerecord (>= 4.0)

    rails (~> 3.2.0) was resolved to 3.2.0, which depends on
      activerecord (= 3.2.0)

EDIT: after looking in the Travis job, saw that it exports a RAILS_VERSION=4.2, now bundle succeeds installing gems

I'm not the Ruby expert yet, so, what should I do to resolve this? (I googled for it and tried several solution :( )

ayashjorden commented 7 years ago

@shadabahmed, I've fixed the tests, sorry that it took a while.

Can you take a look at 1c323ae ?

ayashjorden commented 7 years ago

The checks that are failing are the ruby-head, it fails to install the json gem (building native extension.)

The last successful Travis build was PR#121. It is mentioned here that the libgmp3-dev package is required.

Should I add a before_install section?

ayashjorden commented 7 years ago

@shadabahmed ping...

shadabahmed commented 7 years ago

I can remove ruby head for now.

shadabahmed commented 7 years ago

Thanks for this PR @ayashjorden

Pushed logstasher 1.1.0 to rubygems.org