search

shadabahmed / logstasher

Awesome rails logs
MIT License
821 stars 136 forks source link

Question: Request parameters format? #13

Closed zerobearing2 closed 10 years ago

zerobearing2 commented 10 years ago

Is there a reason you are not leaving parameters as a "Hash"? https://github.com/shadabahmed/logstasher/blob/master/lib/logstasher.rb#L36-L37

payload[:parameters] = payload[:params].except(*ActionController::LogSubscriber::INTERNAL_PARAMS).inject(""){|s,(k,v)|
  s+="#{k}=#{v}\n"}

Would seem more useful to remain a Hash and allow the log entry to be JSON encoded, no?

payload[:parameters] = payload[:params].except(*ActionController::LogSubscriber::INTERNAL_PARAMS)
shadabahmed commented 10 years ago

Yes . .makes sense . .I can change this . .or do you want to submit a pull request ?

zerobearing2 commented 10 years ago

sent PR #14