search

shadabahmed / logstasher

Awesome rails logs
MIT License
818 stars 136 forks source link

[#131] Fix Gem initialization not working on MacOS Sierra and later #132

Closed syndbg closed 7 years ago

syndbg commented 7 years ago

This is a fix for MacOS after https://github.com/shadabahmed/logstasher/commit/dda48f5a3a040c3e1e808ab3c0293e1c147929d6

@shadabahmed

finalwharf commented 7 years ago

Having a test for this would be a good idea! If you can not test for a particular IP, then at least test that default_source returns a printable and readable sequence of characters, not bytes.

shadabahmed commented 7 years ago

Thanks for this PR. Merging it right way and will send you the gem version