search

shadabahmed / logstasher

Awesome rails logs
MIT License
817 stars 136 forks source link

railtie: allow configuring 'log_controller_parameters' through YAML #140

Closed kyrylo closed 5 years ago

kyrylo commented 7 years ago

Follow-up to: https://github.com/shadabahmed/logstasher/commit/90203a7e06fbdcd9fa323723e4874bbce90b6254

I think it would be wise to allow configuring this option through the YAML file because it would be consistent. Right now, users who use the YAML configuration file and want to configure the log_controller_parameters option have to configure logstasher at two places.

phumpal commented 7 years ago

:+1: for consistency! 🎉 🎈 🎁

amitsaxena commented 6 years ago

+1 for this. The Readme doesn't mention that it will not work via .yml and I assumed that it will. It will be great/cleaner to have this merged. The config can then remain at a single location for the people who use .yml.

MMartyn commented 5 years ago

Just adding my +1 to this as well

phumpal commented 5 years ago

@shadabahmed when you have a moment can we get this merged?

shadabahmed commented 5 years ago

Done !

phumpal commented 5 years ago

🎉 🎈 💯 thank you!