search

shadabahmed / logstasher

Awesome rails logs
MIT License
817 stars 136 forks source link

Fix bug in detection of ActiveJob #142

Closed tijmenb closed 6 years ago

tijmenb commented 6 years ago

This method currently assumes that when we run Rails 4.2+, ActiveJob is present. This doesn't account for situations where we explicitly don't include the active job framework.

https://github.com/shadabahmed/logstasher/pull/130 added non-Rails support by selectively requiring the ActiveJob integration. This means the LogStasher::ActiveJob::LogSubscriber won't be loaded if ActiveJob isn't loaded, causing an error.

natematykiewicz commented 6 years ago

I have no idea why I didn't do this in the first place. (I wrote the ActiveJob integration). +1 this PR!

shadabahmed commented 6 years ago

Great. Thanks for the fix. Merged and released in logstasher 1.2.2