Updated ActionController::Instrumentation to allow for multiple libraries to alias process_action method - Githubissues

shadabahmed / logstasher

Awesome rails logs

MIT License

821 stars 136 forks source link

Updated ActionController::Instrumentation to allow for multiple libraries to alias process_action method #145

Closed sanjayginde closed 6 years ago

sanjayginde commented 6 years ago

I ran into an issue integrating DataDog's ddtrace gem with logstasher and traced it to the monkey patching of the ActionController::Instrumentation class, which both gems do. However, Logstasher's didn't allow other gems to patch, so I reorganized it a bit.

~~One issue I have is that this instrumentation spec is failing https://github.com/shadabahmed/logstasher/blob/master/spec/lib/logstasher/instrumentation_spec.rb#L54, but I'm not sure it's necessary.~~

I'm curious if you've encountered this before and if this makes sense.