Rails 6.1 compatibility

shadabahmed / logstasher

Awesome rails logs

MIT License

817 stars 136 forks source link

Rails 6.1 compatibility #156

Closed EtienneDepaulis closed 3 years ago

EtienneDepaulis commented 3 years ago

Fixes NameError: uninitialized constant LogStasher::ActiveJob error when migrating to Rails 6.1

The current version of logstasher relies on ActiveJob::Logging::LogSubscriber which was recently moved to ActiveJob::LogSubscriber in https://github.com/rails/rails/commit/e8b3a46d2eee19eaad89f4b8bdddcf774ac47dbb#diff-607cb532b6032217dc132c06d6822726cdd173c1907c09bddae078e436c50e03

This code is not (yet ?) compatible with Rails <6.1

shadabahmed commented 3 years ago

The builds are broken right now. I am planning to migrate to github actions before I can start fixing issues and make it compatible with latest rails versions

shadabahmed commented 3 years ago

Created a branch with your commits and rails5.2 branch here - https://github.com/shadabahmed/logstasher/tree/rails_6_1

Thanks for helping out. I'll close this branch