search

shadabahmed / logstasher

Awesome rails logs
MIT License
817 stars 136 forks source link

Some initial fixes to get specs running under modern Rails versions #157

Closed petergoldstein closed 3 years ago

petergoldstein commented 3 years ago

This is not complete, but makes some initial fixes to get specs running.

petergoldstein commented 3 years ago

@shadabahmed In case this is helpful.

shadabahmed commented 3 years ago

Thanks so much for this. I was working parallely on this. Hopefully this should help fix the rest of the issues

petergoldstein commented 3 years ago

@shadabahmed Still struggling with the duplicate entries under all Rails version. Not sure why we're seeing 2x entries being written.

shadabahmed commented 3 years ago

Thanks for helping out. Merged your commits in this PR #158 .

There are still two issues failing. It is caused when integration tests are run together with the unit tests. I will close this PR for now

petergoldstein commented 3 years ago

@shadabahmed Sounds good. Thanks.