shadcn-ui / taxonomy

An open source application built using the new router, server components and everything new in Next.js 13.
https://tx.shadcn.com
MIT License
18.64k stars 2.58k forks source link

[Feature Request] Add Hover Shadow Effect to Buttons On Homepage #246

Open SumitKumarDev10 opened 1 year ago

SumitKumarDev10 commented 1 year ago

Summary

Currently, the buttons in the home page lack a hover effect, which could provide visual feedback to users. This issue is opened to propose the addition of a subtle shadow effect when the mouse hovers over buttons.

Expected Behavior

When a user hovers over a button, a smooth and subtle shadow effect should be applied, enhancing the visual feedback and improving the user experience.

Screenshots

image

And

image

Acceptance Criteria

Technical Details

You can use CSS for the same

mardausdennis commented 1 year ago

Using Tailwind CSS's hover state variants and box-shadow utilities, you can achieve the effect. For example:


<button class="bg-blue-500 text-white font-bold py-2 px-4 rounded hover:bg-blue-600 hover:shadow-md">
  Taxonomy
</button>
shiv-2810 commented 1 year ago

this is still open or closed ? can i work on this?

SumitKumarDev10 commented 1 year ago

this is still open or closed ? can i work on this?

Hi @shiv-2810 , I'm actively working on this issue. It's still open, and I'll update it once I have a solution or progress to share.

SumitKumarDev10 commented 1 year ago

Hey Everybody! I have been able to do the shadow hover effect in light color scheme but i am facing some difficulties while implementing the same in dark color scheme. Is there any variable in the code that I can import to taxonomy/app/(marketing)/page.tsx? Please let me know the same. Thank You in advance!😊

Current Status:

image image

Problem:

image
mardausdennis commented 1 year ago

You want to create a shadow effect that adapts to both light and dark themes, you have a couple of options:

  1. Global CSS Class:

    • Implement a class in your globals.css.
    • Define different shadow colors for light and dark modes using CSS variables in :root and .dark.
    • Example:
    
    :root {
    --shadow-color [Your Light Mode Shadow Color];
    }

.dark { --shadow-color [Your Dark Mode Shadow Color]; }


and then use tailwind box-shadow class:
```<button class="bg-indigo-500 shadow-lg shadow-shadow-color">Get Started</button>```

or of course you can also create a custom class and use this

.custom-shadow { box-shadow: var(--shadow-color); }


When you switch to dark mode, the shadow color will change accordingly. This is a clean approach if you use the shadow effect on many elements across your project.

2. **Tailwind's Dark Mode Variant**:
   - Define styles specifically for dark mode using Tailwind's `dark:` variant.
   - Example:


Either approach works well, depending on your project's needs. The global CSS class method provides a centralized solution for multiple elements, while the Tailwind variant offers a quick way to adjust styles for individual components.

Let me know if you have any further questions!
SumitKumarDev10 commented 1 year ago

@mardausdennis Thanks a lot! It really helped me.😊

SumitKumarDev10 commented 1 year ago

Is this better than before?

image image
mardausdennis commented 1 year ago

Looks like you got it to work! 😀 Make sure to close the issue when everything is working fine.

ghost commented 11 months ago

Looks like you got it to work! 😀 Make sure to close the issue when everything is working fine. test