Fix: ApplyPrefix function in CLI not applying prefix correctly in all cases

shadcn-ui / ui

Beautifully designed components that you can copy and paste into your apps. Accessible. Customizable. Open Source.

https://ui.shadcn.com

MIT License

58.6k stars 3.2k forks source link

Open danbt opened 3 weeks ago

danbt commented 3 weeks ago

The Issue

Have a prefix defined in components.json such as "tw-"
Install sonner component with CLI npx shadcn-ui@latest add sonner
See how className string has tw- prefix applied correctly
Notice how toast, description, actionButton, cancelButton do not have tw- prefix applied
The sonner toasts WILL NOT show in browser

Screenshot 2024-04-19 at 10 29 58

The Fix

Apply prefix to property assignments, where they exist as children of an ObjectExpression
Notice how tw- prefix applied correctly

Screenshot 2024-04-19 at 10 34 29

vercel[bot] commented 3 weeks ago

@danbt is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.