search

shadcn-ui / ui

Beautifully designed components that you can copy and paste into your apps. Accessible. Customizable. Open Source.
https://ui.shadcn.com
MIT License
58.57k stars 3.19k forks source link

Refactor: I changed cursor to pointer in dropDownMenuItem for improved usability. #3596

Open L3on06 opened 2 weeks ago

L3on06 commented 2 weeks ago

I optimized the cursor on the dropdown menu item, changing it from the default to a pointer. This enhances the user experience and follows standard practices for improved usability.

OLD

https://github.com/shadcn-ui/ui/assets/96975503/d49853f4-24a6-4263-a418-adbdba91640d

NEW

https://github.com/shadcn-ui/ui/assets/96975503/e32e0984-8dc9-444d-a7ec-5cfe48506abe

vercel[bot] commented 2 weeks ago

@L3on06 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

L3on06 commented 2 weeks ago

Absolutely! Even seemingly small changes like optimizing the cursor on a dropdown menu item can have a significant impact on user experience. By changing it to a pointer, you're providing users with a visual cue that the item is clickable, which can lead to better navigation and interaction. These attention to detail demonstrates a commitment to enhancing usability and adhering to established standards, ultimately contributing to a more polished and user-friendly interface. So yes, these changes are indeed important for improving the overall quality of the product.

gurisko commented 2 weeks ago

I agree with merging this since it fixes wrong UX pattern in UI kit public presentation.

@ruru-m07 What would be the blocker of not merging such a straightforward improvement?

L3on06 commented 2 weeks ago

@gurisko Thanks, Gurisko! Your support means a lot, Appreciate it!

ruru-m07 commented 2 weeks ago

I agree with merging this since it fixes wrong UX pattern in UI kit public presentation.

@ruru-m07 What would be the blocker of not merging such a straightforward improvement?

Mostly @shadcn merge PRs

frederikmartin commented 1 week ago

Same applies for components like SelectItem and CommandItem. Maybe a good idea (once this PR is merged) to check the components for similar UX issues.

L3on06 commented 1 week ago

@frederikmartin Sure, I'm also working on that part. I'll submit a pull request as soon as possible.