search

shadeed / rtl-styling

An extensive guide on how to style for RTL in CSS
https://rtlstyling.com/
MIT License
351 stars 19 forks source link

Toggle Switches #11

Closed ffoodd closed 5 months ago

ffoodd commented 3 years ago

Hi there, me again <3

In the (almost done!) RTL PR in Bootstrap, toggle switches got opposite reviews: after some researches I managed to gather a few references and screenshots to reach a conclusion (comment in PR) but since it's been quite discussed, I think it could be a good candidate for RTL Styling 101.

Moreover, do you agree with my conclusion that Toggle Switches should flip in RTL?

Thanks again for this awesome tool.

shadeed commented 3 years ago

Hello @ffoodd,

Thanks again for the continuous support and help for RTL Styling 101! That means a lot to me. I must admit that I'm a bit busy these days with my job and releasing the book. I hope that I will get some time soon for it as I have lots of ideas and updates to add.

Now to your question, I agree that toggle switches should be flipped in RTL. I did a quick research and found the following from Firefox OS in Arabic

header-standard

So, yes, toggle switches should flip for RTL 😃

ffoodd commented 3 years ago

Thanks, keep going 😉

shadeed commented 5 months ago

I'm embarrassed that it's been over 3 years since this issue was created, but at least I closed it today. Thanks a lot for suggesting it. Fixed in the last commit.