shadeed / rtl-styling

An extensive guide on how to style for RTL in CSS
https://rtlstyling.com/
MIT License
351 stars 19 forks source link

css mistake in the closing example with .c-input--search #14

Open matthewyeow opened 3 years ago

matthewyeow commented 3 years ago

Hi Ahmad,

let me just say it is an amazing guide with so many great pieces of information and clear examples. Thank you for taking the time to write it as I'm sure it will help me avoid a lot of pitfalls!

I noticed in the very last example: Practical Examples where you build a layout, the section with the search bar may have a mistake.

.c-header[dir="rtl"] .c-input--search {
  /* We replace the original icon with a flipped one. */
  background-image: url("data:image/svg+xml...");
  background-position: right 6px center;
}

Should background-position actually be background-position: left 6px center;?