search

shader-slang / slang

Making it easier to work with shaders
http://shader-slang.com
Other
3.17k stars 214 forks source link

CMake support #3283

Closed fknfilewalker closed 12 months ago

fknfilewalker commented 1 year ago

I am surprised that there is no CMake support, It would be really nice to have CMake scripts for slang.

LesleyLai commented 1 year ago

Agreed. Lack of CMake support (and thus hard to build it on multiple platforms) is the main reason I haven't tried this project yet.

csyonghe commented 1 year ago

@fknfilewalker @LesleyLai We do provide binary releases for both Windows and Linux. Which platforms are you on? We can certainly consider providing CMake build files if that is blocking adoption.

LesleyLai commented 1 year ago

Windows and Linux cover my needs, though I generally find building from sources much easier to deal with compared to prebuilt binary.

I see that there is also a vcpkg port of slang though I am not sure how well maintained it is

natevm commented 1 year ago

+1.

CMake is the industry standard when it comes to C++ development. It has its faults for sure, but still, it’s ubiquitous, especially in computer graphics.

If slang were to have some official CMake support, even if it were just a guideline on how to incorporate slang into an existing CMake project, that would probably help adoption quite a bit.

natduca commented 1 year ago

Ellie is on this so setting assignee, and since its in progres putting it onto Q1 but also putting the priority to low to reflect that this might get preempted if something more urgent for this quarter comes up.

gdianaty commented 1 year ago

+1

Regarding @LesleyLai's comment about vcpkg, the current port downloads binaries from GitHub and unzips them into the installed packages directory. Obviously this prevents project-specific dependency wrangling (e.g. slang-gfx library is unconditionally imported). If dependency wrangling is handled via CMake, much of the current Premake complexity in Slang can be reduced as well.