search

shader-slang / slang

Making it easier to work with shaders
MIT License
1.81k stars 161 forks source link

Fix build warnings and treat warnings as error on CI #4276

Closed jkwak-work closed 1 month ago

csyonghe commented 1 month ago

One thing I would like to suggest here is to enable warnings as errors only on CI and not by default. This reduces the friction for users if some later compiler version is producing different set of warnings that are not captured by us.

jkwak-work commented 1 month ago

One thing I would like to suggest here is to enable warnings as errors only on CI and not by default. This reduces the friction for users if some later compiler version is producing different set of warnings that are not captured by us.

That's a good point. I will make sure that only CI will treat warnings as errors.